MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16760.42476.100810.814646@samba.org>
Date: Fri, 22 Oct 2004 16:17:16 +1000
To: Jim Houston <jim.houston@ccur.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: idr in Samba4
In-Reply-To: <1098383538.987.359.camel@new.localdomain>
References: <16759.16648.459393.752417@samba.org>
	<1098383538.987.359.camel@new.localdomain>
Reply-To: tridge@samba.org
From: tridge@samba.org
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 825
Lines: 23

Jim,

 > The attached patch against linux-2.6.9 should do the job without
 > additional overhead.  Andrew, I hope you will add this patch to
 > your tree.

Thanks, that looks good, and it now passes my randomized testsuite.

If you are interested, my test code is at:

  http://samba.org/ftp/unpacked/junkcode/idtree/

Note that I made idr_remove() and sub_remove() return an int for
success/failure, as that was more useful for my code, and it also
means we skip the layer free logic on remove failure (not that it does
any harm, just seems a bit of a loose end).

Cheers, Tridge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/