From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-kernel@vger.kernel.org
Subject: BUG_ONs in signal.c?
Date: Fri, 22 Oct 2004 13:23:49 -0700
User-Agent: KMail/1.7
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200410221323.49298.jbarnes@engr.sgi.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 906
Lines: 17

I recently saw a bug where someone hit the BUG_ON in signal.c after the 
do_coredump code (in my kernel "kernel BUG at signal.c:1614").  After looking 
at it a bit, it seems that we drop the sighand lock prior to calling into the 
core dump routine, which leaves the task vulnerable to having it's group_exit 
or group_exit_code changed either during the coredump or shortly after, 
causing one of the BUG_ONs to trip (in this particular case it was the 
group_exit_code != code check).  Are these BUG_ON checks necessary anymore?  
Or should we be holding the sighand lock all the way until we call do_exit or 
do_group_exit?  Or something else?

Thanks,
Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/