Date: Sat, 23 Oct 2004 12:40:26 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Chris Wright <chrisw@osdl.org>
Cc: akpm@osdl.org, torvalds@osdl.org, Andrea Arcangeli <andrea@novell.com>,
       johansen@immunix.com, Stephen Smalley <sds@epoch.ncsc.mil>,
       Thomas Bleher <bleher@informatik.uni-muenchen.de>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] delay rq_lock acquisition in setscheduler
Message-ID: <20041023104026.GA31448@elte.hu>
References: <20041022125950.X2357@build.pdx.osdl.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041022125950.X2357@build.pdx.osdl.net>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 966
Lines: 23


* Chris Wright <chrisw@osdl.org> wrote:

> Doing access control checks with rq_lock held can cause deadlock when
> audit messages are created (via printk or audit infrastructure) which
> trigger a wakeup and deadlock, as noted by both SELinux and SubDomain
> folks.  This patch will let the security checks happen w/out lock held,
> then re-sample the p->policy in case it was raced.  Originally from John
> Johansen <johansen@immunix.com>, reworked by me.  AFAIK, this version
> drew no objections from Ingo or Andrea.  Please let me know if there's
> any issue with the patch.
> 
> From: John Johansen <johansen@immunix.com>
> Signed-off-by: Chris Wright <chrisw@osdl.org>

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/