Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261198AbUJWOdU (ORCPT ); Sat, 23 Oct 2004 10:33:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261202AbUJWOdU (ORCPT ); Sat, 23 Oct 2004 10:33:20 -0400 Received: from phoenix.infradead.org ([81.187.226.98]:47883 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S261198AbUJWOdR (ORCPT ); Sat, 23 Oct 2004 10:33:17 -0400 Date: Sat, 23 Oct 2004 15:33:09 +0100 From: Christoph Hellwig To: Dave Airlie Cc: Christoph Hellwig , Jon Smirl , lkml Subject: Re: [PATCH} Trivial - fix drm_agp symbol export Message-ID: <20041023143309.GA32417@infradead.org> Mail-Followup-To: Christoph Hellwig , Dave Airlie , Jon Smirl , lkml References: <9e473391041022214570eab48a@mail.gmail.com> <20041023095644.GC30137@infradead.org> <21d7e99704102307287a08247@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21d7e99704102307287a08247@mail.gmail.com> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by phoenix.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 36 On Sun, Oct 24, 2004 at 12:28:18AM +1000, Dave Airlie wrote: > > > > Sorry, wrong API. At least export the individual functions and use them > > directly (and without the symbol_get abnomination that's not any better > > than inter_module_*). > > I wonder what the reasoning behind the old drm_agp structure was in > the first place? > > What about this patch? The patch looks good to me, I really like the reduced complexity. Some minor nitpicks below: + if (!(head = DRM(alloc)(sizeof(*head), DRM_MEM_AGPLISTS))) + return NULL; + memset((void *)head, 0, sizeof(*head)); no need to cast to void * here @@ -428,41 +409,37 @@ */ void DRM(agp_uninit)(void) { - DRM_AGP_PUT; - drm_agp = NULL; } is the function needed by BSD? Else it should probably go away completely. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/