Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261367AbUJXDmW (ORCPT ); Sat, 23 Oct 2004 23:42:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261364AbUJXDmV (ORCPT ); Sat, 23 Oct 2004 23:42:21 -0400 Received: from zeus.kernel.org ([204.152.189.113]:10407 "EHLO zeus.kernel.org") by vger.kernel.org with ESMTP id S261363AbUJXDmD (ORCPT ); Sat, 23 Oct 2004 23:42:03 -0400 Date: Sat, 23 Oct 2004 23:41:52 -0400 To: Adrian Bunk Cc: Andrew Morton , David Hinds , linux-kernel@vger.kernel.org, jgarzik@pobox.com, linux-net@vger.kernel.org, prism54-devel@prism54.org, netdev@oss.sgi.com Subject: Re: 2.6.9-mm1: pc_debug multiple definitions Message-ID: <20041024034152.GB17506@ruslug.rutgers.edu> Mail-Followup-To: Adrian Bunk , Andrew Morton , David Hinds , linux-kernel@vger.kernel.org, jgarzik@pobox.com, linux-net@vger.kernel.org, prism54-devel@prism54.org, netdev@oss.sgi.com References: <20041022032039.730eb226.akpm@osdl.org> <20041022133929.GA2831@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041022133929.GA2831@stusta.de> User-Agent: Mutt/1.3.28i X-Operating-System: 2.4.18-1-686 Organization: Rutgers University Student Linux Users Group From: mcgrof@studorgs.rutgers.edu (Luis R. Rodriguez) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 37 On Fri, Oct 22, 2004 at 03:39:29PM +0200, Adrian Bunk wrote: > > The following compile error comes from Linus' tree: > > > <-- snip --> > > ... > LD drivers/built-in.o > drivers/pcmcia/built-in.o(.bss+0xf20): multiple definition of `pc_debug' > drivers/net/built-in.o(.data+0x24ae0): first defined here > make[1]: *** [drivers/built-in.o] Error 1 > > <-- snip --> > > > The pc_debug in drivers/pcmcia/ds.c was made non-static in Linus' tree, > but the global definition of a global variable with such a generic name > in drivers/net/wireless/prism54/islpci_mgt.c seems to be equally wrong. Great, anyone know why this change was done on ds.c ? The pc_debug on prism54 comes from the original Intersil driver. It is used to for debugging but we should move away from our current debugging mechanism to netif_msg. Margit, do you have some pending commits left? Do you want to take a stab at this? If not I can later on this week. Luis -- GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/