Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261426AbUJXK1r (ORCPT ); Sun, 24 Oct 2004 06:27:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261429AbUJXK1r (ORCPT ); Sun, 24 Oct 2004 06:27:47 -0400 Received: from fw.osdl.org ([65.172.181.6]:8073 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261426AbUJXK1q (ORCPT ); Sun, 24 Oct 2004 06:27:46 -0400 Date: Sun, 24 Oct 2004 03:25:46 -0700 From: Andrew Morton To: Peter Osterlund Cc: linux-kernel@vger.kernel.org, axboe@suse.de Subject: Re: [PATCH] Fix incorrect kunmap_atomic in pktcdvd Message-Id: <20041024032546.52314e23.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 15 Peter Osterlund wrote: > > The pktcdvd driver uses kunmap_atomic() incorrectly. The function is > supposed to take an address as the first parameter, but the pktcdvd > driver passed a page pointer. Thanks to Douglas Gilbert and Jens Axboe > for discovering this. You're about the 7,000th person to make that mistake. We really should catch it via typechecking but the code's really lame and nobody ever got around to rotorooting it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/