Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261706AbUJYJFS (ORCPT ); Mon, 25 Oct 2004 05:05:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261705AbUJYJFS (ORCPT ); Mon, 25 Oct 2004 05:05:18 -0400 Received: from 168.imtp.Ilyichevsk.Odessa.UA ([195.66.192.168]:29195 "HELO port.imtp.ilyichevsk.odessa.ua") by vger.kernel.org with SMTP id S261706AbUJYJFL (ORCPT ); Mon, 25 Oct 2004 05:05:11 -0400 From: Denis Vlasenko To: Andi Kleen Subject: Re: [PATCH] reduce top(1) CPU usage by an order of magnitude Date: Mon, 25 Oct 2004 12:04:45 +0300 User-Agent: KMail/1.5.4 Cc: linux-kernel@vger.kernel.org References: <200410251020.01932.vda@port.imtp.ilyichevsk.odessa.ua.suse.lists.linux.kernel> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200410251204.45940.vda@port.imtp.ilyichevsk.odessa.ua> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 27 On Monday 25 October 2004 10:35, Andi Kleen wrote: > Denis Vlasenko writes: > > > Patch is not mine, Paulo Marques > > wrote it. > > The bug is in your top. It shouldn't read /proc/*/wchan > by default unless the user switches on WCHAN display. > Just disable that and it will be even faster. My top > doesn't read it at all, you probably got some buggy > version. This is top from procps-2.0.18. You are right, top may skip reading wchan, I will look into it. However, if I do request WCHAN, I still want top to be fast. > Also btw we normally let people submit their patches themselves. I just wanted to prevent this patch from being missed. -- vda - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/