Date: Mon, 25 Oct 2004 17:36:15 +0200
From: Dominik Brodowski <linux@dominikbrodowski.de>
To: Stelian Pop <stelian@popies.net>, jgarzik@pobox.com,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pcmcia network drivers cleanup
Message-ID: <20041025153615.GA7730@dominikbrodowski.de>
Mail-Followup-To: Dominik Brodowski <linux@dominikbrodowski.de>,
	Stelian Pop <stelian@popies.net>, jgarzik@pobox.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20041025152121.GA7647@dominikbrodowski.de> <20041025153038.GF3161@crusoe.alcove-fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041025153038.GF3161@crusoe.alcove-fr>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1056
Lines: 30

On Mon, Oct 25, 2004 at 05:30:38PM +0200, Stelian Pop wrote:
> > #define INT_MODULE_PARM(n, v) static int n = v; MODULE_PARM(n, "i")
> > 
> > static int irq_list[4] = { -1 };
> > MODULE_PARM(irq_list, "1-4i");
> > INT_MODULE_PARM(irq_mask,	0xdeb8);
> > 
> > block being replaced with
> > 
> > 
> > static int irq_list[4] = { -1 };
> > static int irq_mask irq_mask = 0xdeb8;
> > 
> > module_parm(irq_mask, int, 0444};
> 
> Sure, it is probably saner, but INT_MODULE_PARM is used for quite a
> few other parameters in each driver, and I didn't want to touch
> all of them.

You need to convert all paramters at once, as MODULE_PARM and module_parm()
can't exist in the same module at the same time anyway. Also, as all
INT_MODULE_PARMs were defined to be MODULE_PARM, it should be safe to do so.

Thanks,
	Dominik
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/