Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262016AbUJYVUw (ORCPT ); Mon, 25 Oct 2004 17:20:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261277AbUJYVI5 (ORCPT ); Mon, 25 Oct 2004 17:08:57 -0400 Received: from mx1.elte.hu ([157.181.1.137]:52701 "EHLO mx1.elte.hu") by vger.kernel.org with ESMTP id S262024AbUJYVBN (ORCPT ); Mon, 25 Oct 2004 17:01:13 -0400 Date: Mon, 25 Oct 2004 23:01:35 +0200 From: Ingo Molnar To: Mark_H_Johnson@raytheon.com Cc: Alexander Batyrshin , Bill Huey , Adam Heath , "K.R. Foley" , linux-kernel@vger.kernel.org, Florian Schmidt , Fernando Pablo Lopez-Lezcano , Lee Revell , Rui Nuno Capela , Thomas Gleixner , Michal Schmidt Subject: Re: [patch] Real-Time Preemption, -RT-2.6.9-mm1-V0 Message-ID: <20041025210135.GA28699@elte.hu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-2.201, required 5.9, BAYES_00 -4.90, SORTED_RECIPS 2.70 X-ELTE-SpamLevel: X-ELTE-SpamScore: -2 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 38 * Mark_H_Johnson@raytheon.com wrote: > BUG: sleeping function called from invalid context hdparm(3606) at > kernel/mutex.c > in_atomic():0 [00000000], irqs_disabled():1 > ... will send stack traceback separately ... > when setting udma2 mode in hdparm. i suspect the patch below will fix the hdparm message - but i dont think it's related to the other problems you have reported. Ingo --- linux/drivers/ide/ide-iops.c.orig +++ linux/drivers/ide/ide-iops.c @@ -783,13 +783,11 @@ int ide_driveid_update (ide_drive_t *dri printk("%s: CHECK for good STATUS\n", drive->name); return 0; } - local_irq_save(flags); - SELECT_MASK(drive, 0); id = kmalloc(SECTOR_WORDS*4, GFP_ATOMIC); - if (!id) { - local_irq_restore(flags); + if (!id) return 0; - } + local_irq_save(flags); + SELECT_MASK(drive, 0); ata_input_data(drive, id, SECTOR_WORDS); (void) hwif->INB(IDE_STATUS_REG); /* clear drive IRQ */ local_irq_enable(); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/