Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261352AbUJZRJG (ORCPT ); Tue, 26 Oct 2004 13:09:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261353AbUJZRIK (ORCPT ); Tue, 26 Oct 2004 13:08:10 -0400 Received: from pfepb.post.tele.dk ([195.41.46.236]:31112 "EHLO pfepb.post.tele.dk") by vger.kernel.org with ESMTP id S261352AbUJZRHv (ORCPT ); Tue, 26 Oct 2004 13:07:51 -0400 Date: Tue, 26 Oct 2004 21:08:15 +0200 From: Sam Ravnborg To: David Vrabel , Linus Torvalds , Len Brown , Benjamin Herrenschmidt , Linux Kernel list Subject: Re: Versioning of tree Message-ID: <20041026190815.GA8338@mars.ravnborg.org> Mail-Followup-To: David Vrabel , Linus Torvalds , Len Brown , Benjamin Herrenschmidt , Linux Kernel list References: <1098254970.3223.6.camel@gaston> <1098256951.26595.4296.camel@d845pe> <20041025234736.GF10638@michonline.com> <417E39AE.5020209@arcom.com> <20041026122632.GH10638@michonline.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041026122632.GH10638@michonline.com> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 35 On Tue, Oct 26, 2004 at 08:26:33AM -0400, Ryan Anderson wrote: > On Tue, Oct 26, 2004 at 12:49:02PM +0100, David Vrabel wrote: > > Ryan Anderson wrote: > > > > > >Well, here's a patch that adds -BKxxxxxxxx to LOCALVERSION when a > > >top-level BitKeeper tree is detected. > > >[...] > > > LOCALVERSION = $(subst $(space),, \ > > > $(shell cat /dev/null $(localversion-files)) \ > > >+ $(subst ",,$(localversion-bk)) \ > > > > Surely there's no need for this? Can't the script spit out an > > appropriate localversion* file instead? > > It can, and yes, my first version used that method. > > Except it never worked. I was able to generate the file before > include/linux/version.h was rebuilt, but failed to get it picked up in > that. I'm not really sure why. The $(wildcard ...) function was executed before you created the file. If we shall retreive the version from a SCM then as you already do must hide it in a script. I want the script only to be executed when we actually ask kbuild to build a kernel - so it has to be part of the prepare rule set. Furthermore I like to avoid a dependency on perl for a basic kernel. Can you retreive the version from bk using a simple shell script? Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/