Date: Tue, 26 Oct 2004 18:06:22 -0700
From: "David S. Miller" <davem@davemloft.net>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: vojtech@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: Input: sunkbd concern
Message-Id: <20041026180622.14fc6268.davem@davemloft.net>
In-Reply-To: <200410221833.04057.dtor_core@ameritech.net>
References: <200410221833.04057.dtor_core@ameritech.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 901
Lines: 25

On Fri, 22 Oct 2004 18:33:04 -0500
Dmitry Torokhov <dtor_core@ameritech.net> wrote:

> I have been looking at sunkbd.c and it seems that it attaches not only to
> ports that speak SUNKBD protocol but also to ports that do not specify any
> protocol:
> 
> 	if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_SUNKBD)
> 		return;
> 
> Was that an oversight or it was done intentionally?

I believe it is intentional.

If SERIO_PROTO bits are all clear, this is supposed to have
a special meaning in that any keyboard driver can claim
the serio line.

So if it's the "wildcard" zero value, or specifically SERIO_SUNKBD,
we'll attach to it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/