Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262303AbUJ0Gue (ORCPT ); Wed, 27 Oct 2004 02:50:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262289AbUJ0Gud (ORCPT ); Wed, 27 Oct 2004 02:50:33 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:63650 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S262318AbUJ0GnO (ORCPT ); Wed, 27 Oct 2004 02:43:14 -0400 Date: Wed, 27 Oct 2004 08:41:46 +0200 From: Jens Axboe To: Andrew Morton Cc: Mathieu Segaud , jfannin1@columbus.rr.com, agk@redhat.com, christophe@saout.de, linux-kernel@vger.kernel.org, bzolnier@gmail.com Subject: Re: 2.6.9-mm1: LVM stopped working (dio-handle-eof.patch) Message-ID: <20041027064146.GG15910@suse.de> References: <87oeitdogw.fsf@barad-dur.crans.org> <1098731002.14877.3.camel@leto.cs.pocnet.net> <20041026123651.GA2987@zion.rivenstone.net> <20041026135955.GA9937@agk.surrey.redhat.com> <20041026213703.GA6174@rivenstone.net> <20041026151559.041088f1.akpm@osdl.org> <87hdogvku7.fsf@barad-dur.crans.org> <20041026222650.596eddd8.akpm@osdl.org> <20041027054741.GB15910@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20041027054741.GB15910@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1457 Lines: 42 On Wed, Oct 27 2004, Jens Axboe wrote: > On Tue, Oct 26 2004, Andrew Morton wrote: > > Mathieu Segaud wrote: > > > > > > Andrew Morton disait derni?rement que : > > > > > > > If you have time, please restore dio-handle-eof.patch and then apply the > > > > below fixup, then retest. Thanks. > > > > > > I had time to test this fix; it did not solve the problem. Whereas reverting > > > the complete dio-handle-eof.patch solved it. > > > > bummer. Can you send a super-simple means by which I can demonstrate the > > problem? > > Hmm, maybe round the value up to a PAGE_SIZE in length? This feels pretty icky, but should suffice for testing. Does it make a difference? --- /opt/kernel/linux-2.6.10-rc1-mm1/fs/direct-io.c 2004-10-27 08:29:51.866931262 +0200 +++ linux-2.6.10-rc1-mm1/fs/direct-io.c 2004-10-27 08:41:20.292172299 +0200 @@ -987,8 +987,8 @@ isize = i_size_read(inode); if (bytes_todo > (isize - offset)) bytes_todo = isize - offset; - if (!bytes_todo) - return 0; + if (bytes_todo < PAGE_SIZE) + bytes_todo = PAGE_SIZE; for (seg = 0; seg < nr_segs && bytes_todo; seg++) { user_addr = (unsigned long)iov[seg].iov_base; -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/