Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262510AbUJ0SEf (ORCPT ); Wed, 27 Oct 2004 14:04:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262546AbUJ0SCx (ORCPT ); Wed, 27 Oct 2004 14:02:53 -0400 Received: from omx1-ext.sgi.com ([192.48.179.11]:15341 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S262568AbUJ0R6O (ORCPT ); Wed, 27 Oct 2004 13:58:14 -0400 Date: Wed, 27 Oct 2004 10:57:21 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: "Chen, Kenneth W" cc: William Lee Irwin III , linux-kernel@vger.kernel.org Subject: RE: Hugepages demand paging V1 [4/4]: Numa patch In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 24 On Mon, 25 Oct 2004, Chen, Kenneth W wrote: > > @@ -32,14 +32,17 @@ > > + struct zonelist *zonelist = NODE_DATA(nid)->node_zonelists; > > + struct zone **zones = zonelist->zones; > > + struct zone *z; > > + int i; > > + > > + for(i=0; (z = zones[i])!= NULL; i++) { > > + nid = z->zone_pgdat->node_id; > > + if (list_empty(&hugepage_freelists[node_id])) > > + break; > > } > > Also this is generic code, we should consider scanning ZONE_HIGHMEM > zonelist. Otherwise, this will likely screw up x86 numa machine. The highmem zones are included in the zones[] array AFAIK. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/