Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262913AbUJ0VcX (ORCPT ); Wed, 27 Oct 2004 17:32:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262728AbUJ0V3X (ORCPT ); Wed, 27 Oct 2004 17:29:23 -0400 Received: from fw.osdl.org ([65.172.181.6]:4251 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262754AbUJ0VYX (ORCPT ); Wed, 27 Oct 2004 17:24:23 -0400 Date: Wed, 27 Oct 2004 14:24:15 -0700 (PDT) From: Linus Torvalds To: Zachary Amsden cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Remove some divide instructions In-Reply-To: <41800218.8090902@vmware.com> Message-ID: References: <417FC982.7070602@vmware.com> <41800218.8090902@vmware.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 965 Lines: 25 On Wed, 27 Oct 2004, Zachary Amsden wrote: > > Passes several tests (code looks sane, assembler looks sane, boots & > runs fine) on i386. Apologies if I unlikely broke any other > architectures, but it's quite difficult to test them all. I'd suggest _only_ changing the i386 version. For example, your asm-generic changes looks senseless, since they only make the macros more complex, without actually changing anything. And the other architectures may want to do other things, since right now at least some of them use things like fixed hardware registers etc which is not necessarily appropriate for the non-asm case... That way you'd also only modify the architecture that you can actually verify.. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/