Date: 28 Oct 2004 13:37:44 +0200
Date: Thu, 28 Oct 2004 13:37:44 +0200
From: Andi Kleen <ak@muc.de>
To: Prasanna S Panchamukhi <prasanna@in.ibm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
       Andrew Morton <akpm@osdl.org>, suparna@in.ibm.com,
       dprobes@www-124.southbury.usf.ibm.com
Subject: Re: [0/3] PATCH Kprobes for x86_64- 2.6.9-final
Message-ID: <20041028113744.GA82042@muc.de>
References: <20041028113208.GA11182@in.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041028113208.GA11182@in.ibm.com>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1149
Lines: 30

On Thu, Oct 28, 2004 at 05:02:08PM +0530, Prasanna S Panchamukhi wrote:
> Hi,
> 
> Below are the Kprobes patches ported to x86_64 architecture.
> I have updated these patches with suggestions from Andi Kleen.
> Thanks Andi for reviewing and providing your feedback.
> These patches can be applied over 2.6.9-final. Please
> see the description in the individual patches.
> 
> Please review and provide your feedback.

The patch is not ready to be applied yet. You didn't address
some issues from the last review.

Like I still would like to have the page fault notifier
completely moved out of the fast path into no_context 
(that i386 has it there is also wrong). Adding kprobe_runn 
doesn't make a difference.

And the jprobe_return_end change is wrong, my suggestion
was to move it into the inline assembler statement. Adding asmlinkage 
doesn't help at all 
(I think i386 gets this wrong too) 

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/