Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263172AbUJ2JLl (ORCPT ); Fri, 29 Oct 2004 05:11:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263173AbUJ2JLl (ORCPT ); Fri, 29 Oct 2004 05:11:41 -0400 Received: from gprs214-50.eurotel.cz ([160.218.214.50]:9856 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S263172AbUJ2JKZ (ORCPT ); Fri, 29 Oct 2004 05:10:25 -0400 Date: Fri, 29 Oct 2004 11:10:12 +0200 From: Pavel Machek To: "Zhu, Yi" Cc: Andrew Morton , Shaohua Li , Linux Kernel Mailing List Subject: Re: [PATCH] [swsusp] print error message when swapping is disabled Message-ID: <20041029091012.GA1003@elf.ucw.cz> References: <16A54BF5D6E14E4D916CE26C9AD3057563D61B@pdsmsx402.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.6+20040722i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 25 Hi! > > Another case is PSE disabled. Should notify this to user also. > > Here is a patch to address it. Patch is okay (but I rararely see this kind of failure in wild). Please submit via akpm. Anyway, the most common problem these days is that one of devices vetoes the suspend. In such case code does the right thing, but without any message to the user... and that is kind of confusing. Patch printing "swsusp failed because device XXXX vetoed it" would be very welcome. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/