Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263267AbUJ2Li3 (ORCPT ); Fri, 29 Oct 2004 07:38:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263305AbUJ2Li2 (ORCPT ); Fri, 29 Oct 2004 07:38:28 -0400 Received: from mxfep01.bredband.com ([195.54.107.70]:35256 "EHLO mxfep01.bredband.com") by vger.kernel.org with ESMTP id S263267AbUJ2Lee convert rfc822-to-8bit (ORCPT ); Fri, 29 Oct 2004 07:34:34 -0400 To: linux-kernel@vger.kernel.org Cc: Andrew Morton , Jan Kara Subject: Re: [PATCH] Configurable Magic Sysrq References: <20041029093941.GA2237@atrey.karlin.mff.cuni.cz> <20041029024651.1ebadf82.akpm@osdl.org> From: =?iso-8859-1?q?M=E5ns_Rullg=E5rd?= Date: Fri, 29 Oct 2004 13:34:09 +0200 In-Reply-To: <20041029024651.1ebadf82.akpm@osdl.org> (Andrew Morton's message of "Fri, 29 Oct 2004 02:46:51 -0700") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Security Through Obscurity, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 37 Andrew Morton writes: > Jan Kara wrote: >> >> I know about a few people who would like to use some functionality of >> the Magic Sysrq but don't want to enable all the functions it provides. > > That's a new one. Can you tell us more about why people want to do such a > thing? > >> So I wrote a patch which should allow them to do so. It allows to >> configure available functions of Sysrq via /proc/sys/kernel/sysrq (the >> interface is backward compatible). If you think it's useful then use it :) >> Andrew, do you think it can go into mainline or it's just an overdesign? > > Patch looks reasonable - we just need to decide whether the requirement > warrants its inclusion. > > There have been a few changes in the sysrq code since 2.6.9 and there are > more changes queued up in -mm. The patch applies OK, but it'll need > checking and redoing. There's a new `sysrq-f' command in the pipeline > which causes a manual oom-killer call. See also the patch I just posted to lkml. I also thought of an improved way of selecting keys to enable. Instead of an arbitrary bitmask, would it be possible to simply list the keys you want to enable, such as "echo sku > /proc/sys/kernel/sysrq"? -- M?ns Rullg?rd mru@inprovide.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/