Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263300AbUJ2L4g (ORCPT ); Fri, 29 Oct 2004 07:56:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263250AbUJ2Lxh (ORCPT ); Fri, 29 Oct 2004 07:53:37 -0400 Received: from phoenix.infradead.org ([81.187.226.98]:44804 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S263290AbUJ2Lwq (ORCPT ); Fri, 29 Oct 2004 07:52:46 -0400 Date: Fri, 29 Oct 2004 12:52:33 +0100 From: Christoph Hellwig To: Pekka Enberg Cc: davem@davemloft.net, netdev@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 0/3] net: generic netdev_ioaddr Message-ID: <20041029115233.GA11391@infradead.org> Mail-Followup-To: Christoph Hellwig , Pekka Enberg , davem@davemloft.net, netdev@oss.sgi.com, linux-kernel@vger.kernel.org References: <1099044244.9566.0.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1099044244.9566.0.camel@localhost> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by phoenix.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 23 On Fri, Oct 29, 2004 at 01:04:04PM +0300, Pekka Enberg wrote: > Hi, > > This patch introduces a generic netdev_ioaddr and converts natsemi and > 8139too drivers to use it. > > With the recent __iomem annotations, the network drivers need to either > invent this wrapper (like natsemi has done) or duplicate the IO base > address in their private data (similar to 8139too). Therefore, lets > make netdev_ioaddr generic before it is all over the place. This casting around sounds like a bad idea. Either add another void __iomem *mmioaddr; member to struct net_device, or better move that completely into the driver-private structure which seems the better level of abstraction. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/