Date: Fri, 29 Oct 2004 16:16:48 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Pantelis Antoniou <panto@intracom.gr>
Cc: Tom Rini <trini@kernel.crashing.org>,
       Linuxppc-Embedded <linuxppc-embedded@lists.linuxppc.org>,
       Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix early request_irq
Message-ID: <20041029141648.GB25204@elte.hu>
References: <41824E15.4090906@intracom.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <41824E15.4090906@intracom.gr>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 763
Lines: 24


* Pantelis Antoniou <panto@intracom.gr> wrote:

> Hi there
> 
> The recent consolidation of the IRQ code has caused
> a number of PPC embedded cpus to stop working.
> 
> The problem is that on init_IRQ these platforms call
> request_irq very early, which in turn calls kmalloc
> without the memory subsystem being initialized.
> 
> The following patch fixes it by keeping a small static
> array of irqactions just for this purpose.

this is quite broken. Those places should use setup_irq(),
not request_irq().

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/