Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263378AbUJ2Pfr (ORCPT ); Fri, 29 Oct 2004 11:35:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263384AbUJ2Pfq (ORCPT ); Fri, 29 Oct 2004 11:35:46 -0400 Received: from fire.osdl.org ([65.172.181.4]:48807 "EHLO fire-1.osdl.org") by vger.kernel.org with ESMTP id S263378AbUJ2Osw (ORCPT ); Fri, 29 Oct 2004 10:48:52 -0400 Subject: Re: [patch] 2.6.10-rc1: SCSI aacraid warning From: Mark Haverkamp To: Adrian Bunk Cc: Linus Torvalds , linux-kernel , James Bottomley , linux-scsi In-Reply-To: <20041029143712.GM6677@stusta.de> References: <20041029143712.GM6677@stusta.de> Content-Type: text/plain Date: Fri, 29 Oct 2004 07:45:34 -0700 Message-Id: <1099061134.13961.2.camel@markh1.pdx.osdl.net> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 (2.0.2-3) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1560 Lines: 54 On Fri, 2004-10-29 at 16:37 +0200, Adrian Bunk wrote: > On Fri, Oct 22, 2004 at 03:05:13PM -0700, Linus Torvalds wrote: > >... > > Summary of changes from v2.6.9 to v2.6.10-rc1 > > ============================================ > >... > > Mark Haverkamp: > >... > > o aacraid: dynamic dev update > >... > > > This causes the following warning with a recent gcc: > > <-- snip --> > > ... > CC drivers/scsi/aacraid/aachba.o > drivers/scsi/aacraid/aachba.c: In function `aac_scsi_cmd': > drivers/scsi/aacraid/aachba.c:1140: warning: integer constant is too large for "long" type > ... > > <-- snip --> > > > The fix is simple: > > > Signed-off-by: Adrian Bunk > > --- linux-2.6.10-rc1-mm2-full/drivers/scsi/aacraid/aachba.c.old 2004-10-29 16:16:52.000000000 +0200 > +++ linux-2.6.10-rc1-mm2-full/drivers/scsi/aacraid/aachba.c 2004-10-29 16:22:14.000000000 +0200 > @@ -1137,7 +1137,7 @@ > char *cp; > > dprintk((KERN_DEBUG "READ CAPACITY command.\n")); > - if (fsa_dev_ptr[cid].size <= 0x100000000) > + if (fsa_dev_ptr[cid].size <= 0x100000000ULL) > capacity = fsa_dev_ptr[cid].size - 1; > else > capacity = (u32)-1; Sorry about that, I have it fixed in my working version. I must have forgotten to add it to the patch. -- Mark Haverkamp - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/