Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263401AbUJ2QOM (ORCPT ); Fri, 29 Oct 2004 12:14:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263409AbUJ2QMF (ORCPT ); Fri, 29 Oct 2004 12:12:05 -0400 Received: from hermes.domdv.de ([193.102.202.1]:12299 "EHLO hermes.domdv.de") by vger.kernel.org with ESMTP id S263440AbUJ2QGY (ORCPT ); Fri, 29 Oct 2004 12:06:24 -0400 Message-ID: <41826A7E.6020801@domdv.de> Date: Fri, 29 Oct 2004 18:06:22 +0200 From: Andreas Steinmetz User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040918 X-Accept-Language: en-us, en, de MIME-Version: 1.0 To: Linus Torvalds CC: linux-os@analogic.com, Kernel Mailing List , Richard Henderson , Andi Kleen , Andrew Morton , Jan Hubicka Subject: Re: Semaphore assembly-code bug References: <417550FB.8020404@drdos.com> <1098218286.8675.82.camel@mentorng.gurulabs.com> <41757478.4090402@drdos.com> <20041020034524.GD10638@michonline.com> <1098245904.23628.84.camel@krustophenia.net> <1098247307.23628.91.camel@krustophenia.net> In-Reply-To: X-Enigmail-Version: 0.86.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 23 Linus Torvalds wrote: > > On Fri, 29 Oct 2004, linux-os wrote: > >>Linus, please check this out. > > > Yes, I concur. However, I'd suggest changing the "addl $4,%esp" into a > "popl %ecx", which is smaller and apparently faster on some CPU's (ecx > obviously gets immediately overwritten by the next popl). Hmm, I didn't check the instruction length but modern CPUs usually work best with the following: leal 4(%esp),%esp -- Andreas Steinmetz SPAMmers use robotrap@domdv.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/