Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263572AbUJ3BiK (ORCPT ); Fri, 29 Oct 2004 21:38:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261263AbUJ2Th5 (ORCPT ); Fri, 29 Oct 2004 15:37:57 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:12168 "EHLO mail.cs.helsinki.fi") by vger.kernel.org with ESMTP id S261300AbUJ2SuV (ORCPT ); Fri, 29 Oct 2004 14:50:21 -0400 References: <1099044244.9566.0.camel@localhost> <20041029131607.GU24336@parcelfarce.linux.theplanet.co.uk> In-Reply-To: <20041029131607.GU24336@parcelfarce.linux.theplanet.co.uk> From: "Pekka J Enberg" To: Al Viro Cc: davem@davemloft.net, netdev@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: net: generic netdev_ioaddr Date: Fri, 29 Oct 2004 21:50:20 +0300 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="utf-8,iso-8859-1" Content-Transfer-Encoding: 7bit Message-ID: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 22 Hi, Al Viro writes: > NAK. ->base_addr casting is a Bad Idea(tm) and natsemi "solution" isn't > (thanks for spotting that crap in natsemi, though; will fix...) > > Note that there is no such thing as "generic IO base address" - it _is_ > private and in the best case current ->base_addr is a scratch register > probably used for something vaguely connected with some IO, but it's > really up to driver... Yup, I thought about that after I sent the patch. However, as it stands now, many network drivers use netdev->base_addr for just that. Perhaps it should be nuked completely instead? Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/