From: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
To: Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] efs: make a struct static
Date: Sun, 31 Oct 2004 00:41:25 +0300
User-Agent: KMail/1.5.4
References: <20041030175636.GP4374@stusta.de>
In-Reply-To: <20041030175636.GP4374@stusta.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="koi8-r"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200410310041.25152.vda@port.imtp.ilyichevsk.odessa.ua>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 50

On Saturday 30 October 2004 20:56, Adrian Bunk wrote:
> The patch below makes a struct in the efs code static.
> 
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.6.10-rc1-mm2-full/include/linux/efs_vh.h.old	2004-10-30 14:03:58.000000000 +0200
> +++ linux-2.6.10-rc1-mm2-full/include/linux/efs_vh.h	2004-10-30 14:04:13.000000000 +0200
> @@ -44,7 +44,7 @@
>  #define SGI_EFS		0x07
>  #define IS_EFS(x)	(((x) == SGI_EFS) || ((x) == SGI_SYSV))
>  
> -struct pt_types {
> +static struct pt_types {
>  	int	pt_type;
>  	char	*pt_name;
>  } sgi_pt_types[] = {

You made a variable in .h file static. This is a no-no.

Only fs/efs/super.c includes linux/efs_vh.h now, but if
it will be ever included into another files, you
will get silent data duplication.

Unless I miss something, you really wanted to do:

.h file:

struct pt_types {
	int     pt_type;
	char    *pt_name;
};
extern struct pt_types sgi_pt_types[];

.c file:

struct pt_types sgi_pt_types[] = {
	{0x00,          "SGI vh"},
....
	{0,             NULL}
};

--
vda

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/