Date: Sun, 31 Oct 2004 02:48:40 -0800
From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: geert@linux-m68k.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
       linux-net@vger.kernel.org
Subject: Re: [PATCH 475] HP300 LANCE
Message-Id: <20041031024840.6eeee92d.akpm@osdl.org>
In-Reply-To: <4184C16E.80705@pobox.com>
References: <200410311003.i9VA3UMN009557@anakin.of.borg>
	<4184BB09.8000107@pobox.com>
	<20041031021933.1eba86a6.akpm@osdl.org>
	<4184C16E.80705@pobox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1065
Lines: 33

Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Andrew Morton wrote:
> > Jeff Garzik <jgarzik@pobox.com> wrote:
> > 
> >>content looks OK, but patch appears to be whitespace-challenged...
> >>
> > 
> > 
> > It applies successfully.
> 
> I'm talking about the _other_ type of "whitespace challenged", such as,
> 
> -        volatile struct lance_regs *ll;
> +	unsigned long base;
> 
> 	and
> 
> -        void *va = dio_scodetoviraddr(scode);
> +	unsigned long pa = dio_scodetophysaddr(scode);
> +        unsigned long va = (pa + DIO_VIRADDRBASE);
> 
> Reading through the patch you can see other one-space-off spots.
> 

That's because the stoopid driver is using spaces instead of tabs all over
the place.  It comes out visually OK once the patch is applied.  But it's a
useful reminder of how much dreck we have in the tree.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/