Date: Sun, 31 Oct 2004 03:09:31 -0800
From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: geert@linux-m68k.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
       linux-net@vger.kernel.org
Subject: Re: [PATCH 475] HP300 LANCE
Message-Id: <20041031030931.3d592bf2.akpm@osdl.org>
In-Reply-To: <20041031105724.GA28012@havoc.gtf.org>
References: <200410311003.i9VA3UMN009557@anakin.of.borg>
	<4184BB09.8000107@pobox.com>
	<20041031021933.1eba86a6.akpm@osdl.org>
	<4184C16E.80705@pobox.com>
	<20041031024840.6eeee92d.akpm@osdl.org>
	<20041031105724.GA28012@havoc.gtf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1009
Lines: 24

Jeff Garzik <jgarzik@pobox.com> wrote:
>
> On Sun, Oct 31, 2004 at 02:48:40AM -0800, Andrew Morton wrote:
>  > > -        void *va = dio_scodetoviraddr(scode);
>  > > +	unsigned long pa = dio_scodetophysaddr(scode);
>  > > +        unsigned long va = (pa + DIO_VIRADDRBASE);
> 
> 
>  > That's because the stoopid driver is using spaces instead of tabs all over
>  > the place.  It comes out visually OK once the patch is applied.  But it's a
>  > useful reminder of how much dreck we have in the tree.
> 
>  Did you see the above quoted patch chunk?  The patch is inconsistent
>  with _itself_, adding 'pa' and 'va' with different idents (but when they
>  should be at the same identation level).

Trust me ;)

http://www.zip.com.au/~akpm/linux/patches/stuff/x.jpg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/