Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261230AbUKBOIi (ORCPT ); Tue, 2 Nov 2004 09:08:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261657AbUKBN76 (ORCPT ); Tue, 2 Nov 2004 08:59:58 -0500 Received: from mx2.elte.hu ([157.181.151.9]:28596 "EHLO mx2.elte.hu") by vger.kernel.org with ESMTP id S261230AbUKBNew (ORCPT ); Tue, 2 Nov 2004 08:34:52 -0500 Date: Tue, 2 Nov 2004 14:35:18 +0100 From: Ingo Molnar To: Bill Huey Cc: Michal Schmidt , linux-kernel@vger.kernel.org, Lee Revell , Rui Nuno Capela , Mark_H_Johnson@Raytheon.com, "K.R. Foley" , Adam Heath , Florian Schmidt , Thomas Gleixner , Fernando Pablo Lopez-Lezcano , Karsten Wiese Subject: Re: [patch] Real-Time Preemption, -RT-2.6.9-mm1-V0.5 (networking problems) Message-ID: <20041102133518.GA19755@elte.hu> References: <20041027001542.GA29295@elte.hu> <417F7D7D.5090205@stud.feec.vutbr.cz> <20041027134822.GA7980@elte.hu> <417FD9F2.8060002@stud.feec.vutbr.cz> <20041028115719.GA9563@elte.hu> <20041030000234.GA20986@nietzsche.lynx.com> <20041102085650.GA3973@nietzsche.lynx.com> <20041102093758.GA28014@elte.hu> <20041102110810.GA11393@nietzsche.lynx.com> <20041102114522.GA7874@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041102114522.GA7874@elte.hu> User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 46 * Ingo Molnar wrote: > > getting closer... > > > > http:590 BUG: lock held at task exit time! > > [c03f9e84] {r:0,a:-1,kernel_sem.lock} > > .. held by: http/ 590 [dc0508a0, 121] > > ... acquired at: __schedule+0x3ac/0x850 > > hm. Something called do_exit() with the BKL held which is a no-no. Do > you have a stacktrace, is this sys_exit() or some other code calling > do_exit()? ok, Thomas reported a similar one too, which comes from the NFS code. Does the patch below fix the warning? Ingo --- linux/kernel/module.c.orig +++ linux/kernel/module.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include #include @@ -97,6 +98,11 @@ static inline int strong_try_module_get( void __module_put_and_exit(struct module *mod, long code) { module_put(mod); + /* + * Release the kernel lock if held: + */ + while (current->lock_depth != -1) + unlock_kernel(); do_exit(code); } EXPORT_SYMBOL(__module_put_and_exit); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/