Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 24 Apr 2001 03:59:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 24 Apr 2001 03:59:19 -0400 Received: from juicer13.bigpond.com ([139.134.6.21]:18911 "EHLO mailin1.bigpond.com") by vger.kernel.org with ESMTP id ; Tue, 24 Apr 2001 03:59:06 -0400 Message-Id: From: Rusty Russell To: Jesper Juhl Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] pedantic code cleanup - am I wasting my time with this? In-Reply-To: Your message of "Mon, 23 Apr 2001 17:26:27 +0200." <3AE449A3.3050601@eisenstein.dk> Date: Tue, 24 Apr 2001 14:59:15 +1000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org In message <3AE449A3.3050601@eisenstein.dk> you write: > return (waitall ? len : min(sk->rcvlowat, len)) ? : 1; > > To be strictly correct the second expression (between '?' and ':' ) > should not be omitted (all you guys already know that ofcourse). It's a GCC extension. From Documentation/DocBook/kernel-hacking.tmpl: GNU Extensions are explicitly allowed in the Linux kernel. Rusty. -- Premature optmztion is rt of all evl. --DK - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/