Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262068AbUKDEzi (ORCPT ); Wed, 3 Nov 2004 23:55:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262070AbUKDEzi (ORCPT ); Wed, 3 Nov 2004 23:55:38 -0500 Received: from ozlabs.org ([203.10.76.45]:38105 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S262068AbUKDEzc (ORCPT ); Wed, 3 Nov 2004 23:55:32 -0500 Subject: Re: [PATCH] [CPU-HOTPLUG] convert cpucontrol to be a rwsem From: Rusty Russell To: Dominik Brodowski Cc: Zwane Mwaikambo , lkml - Kernel Mailing List In-Reply-To: <20041102222819.GA16414@dominikbrodowski.de> References: <20041101084337.GA7824@dominikbrodowski.de> <20041102222819.GA16414@dominikbrodowski.de> Content-Type: text/plain Date: Thu, 04 Nov 2004 12:57:17 +1100 Message-Id: <1099533437.7143.5.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 21 On Tue, 2004-11-02 at 23:28 +0100, Dominik Brodowski wrote: > Except that we don't want to (and can't[*]) disable preemption in the > cpufreq case. Therefore, we __need__ to disable CPU hotplug specifically, > and not meddle with other issues like preemption, scheduling, CPUs which are > in the allowed_map, and so on. So back to the original patch: Rusty, do you > agree with it? Sure. I consider it a trivial change. The reason it wasn't a rwsem in the first place is that there weren't many places which needed to grab it, and none were time-sensitive. Thanks! Rusty. -- A bad analogy is like a leaky screwdriver -- Richard Braakman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/