Message-ID: <3AE55DD0.D4C334D7@mandrakesoft.com>
Date: Tue, 24 Apr 2001 07:04:48 -0400
From: Jeff Garzik <jgarzik@mandrakesoft.com>
Organization: MandrakeSoft
MIME-Version: 1.0
To: Steven Walter <srwalter@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: serial driver not properly detecting modem
In-Reply-To: <20010423223847.A3945@hapablap.dyn.dhs.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Steven Walter wrote:
> 
> It would seem that I have a modem (hardware based, not winmodem) of
> PCI_CLASS_COMMUNICATION_OTHER.  This, unfortunately, prevents it from
> being automagically detected by the serial driver, which only looks for
> devices of 
> 
> I've fixed this here merely by adding an entry to the PCI table of
> serial.c for PCI_CLASS_COMMUNICATION_OTHER.  Is this the best way to fix
> this?  Is there some reason that this shouldn't be done in general?  If
> not, I'd like to see it fix in the kernel proper.

That won't work for a general rule, since winmodems list themselves as
'OTHER' too.  Just add your PCI id above the
PCI_CLASS_COMMUNICATION_SERIAL.

Make sure you cc me and tytso@mit.edu on such a patch...

-- 
Jeff Garzik      | The difference between America and England is that
Building 1024    | the English think 100 miles is a long distance and
MandrakeSoft     | the Americans think 100 years is a long time.
                 |      (random fortune)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/