Subject: RE: patch for sysfs in the cyclades driver
From: Germano <germano.barreiro@cyclades.com>
Reply-To: germano.barreiro@cyclades.com
To: "Kilau, Scott" <Scott_Kilau@digi.com>
Cc: Greg KH <greg@kroah.com>, Roland Dreier <roland@topspin.com>,
       Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
       linux-kernel@vger.kernel.org
In-Reply-To: <71A17D6448EC0140B44BCEB8CD0DA36E041BF5BC@minimail.digi.com>
References: <71A17D6448EC0140B44BCEB8CD0DA36E041BF5BC@minimail.digi.com>
Content-Type: text/plain; charset=iso-8859-1
Organization: Cyclades Latin America
Message-Id: <1099592893.2161.6.camel@tsthost>
Mime-Version: 1.0
Date: Thu, 04 Nov 2004 16:28:13 -0200
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1433
Lines: 39

I send my thanks to all too. Finally (I hope no new problems appear) the
exit of the maze :)


Em Qui, 2004-11-04 ?s 15:50, Kilau, Scott escreveu:
> > > and the implementation in in drivers/scsi/st.c, that there's no
> > > problem adding attributes to a device in a simple class.  You can
> just
> > > use class_set_devdata() on your class_device to set whatever context
> > > you need to get back to your internal structures, and then use
> > > class_device_create_file() to add the attributes.
> > > 
> > > I assume this is OK (since there is already one in-kernel driver
> doing
> > > it), but Greg, can you confirm that it's definitely OK for a driver
> to
> > > use class_set_devdata() on a class_device from
> class_simple_device_add()?
> 
> > Hm, I think that should be ok, but I'd make sure to test it before
> > verifying that it really is :)
> 
> I have just added this code and tested it, and indeed it *does* work!
> 
> So I will graciously redraw my comments from my previous email.
> It works, and this is definitely the way Germano and I should go in
> each of our respective drivers.
> 
> Thanks again for everyones comments/help!
> 
> Scott Kilau
> Digi International
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/