Date: Thu, 4 Nov 2004 09:44:11 -0800
From: Greg KH <greg@kroah.com>
To: Roland Dreier <roland@topspin.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
       Germano <germano.barreiro@cyclades.com>, Scott_Kilau@digi.com,
       linux-kernel@vger.kernel.org
Subject: Re: patch for sysfs in the cyclades driver
Message-ID: <20041104174411.GE16389@kroah.com>
References: <1099487348.1428.16.camel@tsthost> <20041104102505.GA8379@logos.cnet> <52fz3po8k2.fsf@topspin.com> <20041104142925.GB9431@logos.cnet> <523bzpo6m2.fsf@topspin.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <523bzpo6m2.fsf@topspin.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1054
Lines: 25

On Thu, Nov 04, 2004 at 09:40:21AM -0800, Roland Dreier wrote:
>     Marcelo> ------ Greg answer was:
> 
>     Greg> For a driver only attribute, you want them to show up in the
>     Greg> place for the driver (like under
>     Greg> /sys/bus/pci/driver/MY_FOO_DRIVER/).  To do that use the
>     Greg> DRIVER_ATTR() and the driver_add_file() functions.  For
>     Greg> examples, see the other drivers that use these functions.
> 
> I think Greg may have misunderstood the question and told you how to
> expose per-driver attributes.  But I think the attributes you want
> really are per-device and should be attached to the class_device, not
> the driver.

Heh, yes.  Per-driver attributes go in the driver's directory.  Per port
attributes go in the port's directory.  Simple as that :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/