Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261349AbUKFJsU (ORCPT ); Sat, 6 Nov 2004 04:48:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261351AbUKFJsU (ORCPT ); Sat, 6 Nov 2004 04:48:20 -0500 Received: from bay-bridge.veritas.com ([143.127.3.10]:12750 "EHLO MTVMIME01.enterprise.veritas.com") by vger.kernel.org with ESMTP id S261349AbUKFJsR (ORCPT ); Sat, 6 Nov 2004 04:48:17 -0500 Date: Sat, 6 Nov 2004 09:47:56 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@localhost.localdomain To: Andrea Arcangeli cc: Nick Piggin , Jesse Barnes , Marcelo Tosatti , Andrew Morton , , Subject: Re: [PATCH] Remove OOM killer from try_to_free_pages / all_unreclaimable braindamage In-Reply-To: <20041106015051.GU8229@dualathlon.random> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 590 Lines: 15 On Sat, 6 Nov 2004, Andrea Arcangeli wrote: > > all allocations should have a failure path to avoid deadlocks. But in > the meantime __GFP_REPEAT is at least localizing the problematic places ;) Problematic, yes: don't overlook that GFP_REPEAT and GFP_NOFAIL _can_ fail, returning NULL: when the process is being OOM-killed (PF_MEMDIE). Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/