Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261363AbUKFKxK (ORCPT ); Sat, 6 Nov 2004 05:53:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261364AbUKFKxJ (ORCPT ); Sat, 6 Nov 2004 05:53:09 -0500 Received: from mail-08.iinet.net.au ([203.59.3.40]:53980 "HELO mail.iinet.net.au") by vger.kernel.org with SMTP id S261363AbUKFKxF (ORCPT ); Sat, 6 Nov 2004 05:53:05 -0500 Message-ID: <418CAD0C.3030109@cyberone.com.au> Date: Sat, 06 Nov 2004 21:53:00 +1100 From: Nick Piggin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040820 Debian/1.7.2-4 X-Accept-Language: en MIME-Version: 1.0 To: Hugh Dickins CC: Andrea Arcangeli , Jesse Barnes , Marcelo Tosatti , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] Remove OOM killer from try_to_free_pages / all_unreclaimable braindamage References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 25 Hugh Dickins wrote: >On Sat, 6 Nov 2004, Andrea Arcangeli wrote: > >>all allocations should have a failure path to avoid deadlocks. But in >>the meantime __GFP_REPEAT is at least localizing the problematic places ;) >> > >Problematic, yes: don't overlook that GFP_REPEAT and GFP_NOFAIL _can_ >fail, returning NULL: when the process is being OOM-killed (PF_MEMDIE). > > Yeah right you are. I think NOFAIL is a bug and should really not fail. It looks like it is only used in fs/jbd/*, and things will crash if it fails. Maybe they're only called from the kjournald threads and can't be OOM killed, but that is still a pretty subtle dependancy. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/