Message-ID: <418D179D.50301@verizon.net>
Date: Sat, 06 Nov 2004 13:27:41 -0500
From: Jim Nelson <james4765@verizon.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
MIME-Version: 1.0
To: Jeff Garzik <jgarzik@pobox.com>
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hw_random: Update printk()'s in hw_random.c
References: <20041105211912.17210.55119.84600@localhost.localdomain> <418D0623.8000302@pobox.com>
In-Reply-To: <418D0623.8000302@pobox.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1119
Lines: 40

>>  /*
>>   * debugging macros
>>   */
>> -#undef RNG_DEBUG /* define to enable copious debugging info */
>> +#undef DEBUG /* define to enable copious debugging info */
> 
> 
> I think the '#undef DEBUG' line is supposed to precede all the 
> #includes, yes?
> 
> 

>>  static int rng_dev_open (struct inode *inode, struct file *filp);
>>  static ssize_t rng_dev_read (struct file *filp, char __user *buf, 
>> size_t size,
>> -                 loff_t * offp);
>> +        loff_t * offp);
> 
> 
> seemingly bogus whitespace change
> 
> 

>> -    bytes_out = xstore(&via_rng_datum, VIA_RNG_CHUNK_1) & 
>> VIA_XSTORE_CNT_MASK;
>> +    bytes_out = xstore(&via_rng_datum, VIA_RNG_CHUNK_1) &
>> +            VIA_XSTORE_CNT_MASK;
> 
> 
> bogus whitespace change
> -


All right.  I'll back out the whitespace changes and move the #undef to the top of 
the #includes, and re-submit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/