Date: Sun, 7 Nov 2004 04:49:27 +0000 (GMT)
From: Hugh Dickins <hugh@veritas.com>
To: Chiaki <ishikawa@yk.rim.or.jp>
cc: linux-kernel@vger.kernel.org
Subject: Re: Configuration system bug? : tmpfs listing in /proc/filesystems
    when TMPFS was not configured!?
In-Reply-To: <418D8470.9070907@yk.rim.or.jp>
Message-ID: <Pine.LNX.4.44.0411070436080.12803-100000@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1208
Lines: 38

On Sun, 7 Nov 2004, Chiaki wrote:
> Should not this line be ifdef'ed out???
> That is, should we modify the line like this?
> 
> #ifdef CONFIG_TMPFS
> 	error = register_filesystem(&tmpfs_fs_type);
> #endif

I'd be more inclined to register under a different
name than "tmpfs" in the !CONFIG_TMPFS case.

But as I said in my earlier reply to you (which you should have
received before you sent this?), it's been like this ever since
2.4.4 when "tmpfs" and CONFIG_TMPFS came into being, so I don't
see why we need to change it now.

The real 2.4.9 error is fixed by the patch below that I sent then:
does that solve your problems?

Hugh

--- 2.6.9/mm/shmem.c	2004-10-18 22:56:29.000000000 +0100
+++ linux/mm/shmem.c	2004-11-06 21:04:41.743173040 +0000
@@ -1904,6 +1904,8 @@ static int shmem_fill_super(struct super
 		sbinfo->max_inodes = inodes;
 		sbinfo->free_inodes = inodes;
 	}
+#else
+	sb->s_flags |= MS_NOUSER;
 #endif
 
 	sb->s_maxbytes = SHMEM_MAX_BYTES;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/