Date: Mon, 8 Nov 2004 09:55:48 +0100
From: Jens Axboe <axboe@suse.de>
To: Chris Wedgwood <cw@f00f.org>
Cc: Ross Biro <ross.biro@gmail.com>,
       Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
       Jeff Garzik <jgarzik@pobox.com>, LKML <linux-kernel@vger.kernel.org>,
       Andre Hedrick <andre@pyxtechnologies.com>
Subject: Re: [PATCH 2/3] WIN_* -> ATA_CMD_* conversion: update WIN_* users to use ATA_CMD_*
Message-ID: <20041108085545.GI29120@suse.de>
References: <20041103091101.GC22469@taniwha.stupidest.org> <418AE8C0.3040205@pobox.com> <58cb370e041105051635c15281@mail.gmail.com> <20041106032314.GC6060@taniwha.stupidest.org> <8783be660411051945252097c3@mail.gmail.com> <20041106035522.GA13091@taniwha.stupidest.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041106035522.GA13091@taniwha.stupidest.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 918
Lines: 23

On Fri, Nov 05 2004, Chris Wedgwood wrote:
> > In particular, most Maxtor and Western Digital Drives will not
> > recover from errors with this command sequence.  The preferred error
> > recovery is to do a reset followed by a set features, because that
> > is what Windows does (as told to me by a drive vendor).
> 
> I assume for Windows they do that for all drives?  Even older ones?
> 
> I also wonder what happens with TCQ when you get an error?  Do you
> just retry everything outstanding?

Any error typically causes an invalidation of the queue, so yes you just
start from scratch. Since PATA doesn't support TCQ anymore, it's not a
worry though :)

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/