Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261821AbUKHMGE (ORCPT ); Mon, 8 Nov 2004 07:06:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261818AbUKHMGE (ORCPT ); Mon, 8 Nov 2004 07:06:04 -0500 Received: from canuck.infradead.org ([205.233.218.70]:52492 "EHLO canuck.infradead.org") by vger.kernel.org with ESMTP id S261807AbUKHMF5 (ORCPT ); Mon, 8 Nov 2004 07:05:57 -0500 Subject: Re: [PATCH] Fix O_SYNC speedup for generic_file_write_nolock From: Arjan van de Ven To: suparna@in.ibm.com Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org In-Reply-To: <20041108115353.GA4068@in.ibm.com> References: <20041108100738.GA4003@in.ibm.com> <1099908278.3577.2.camel@laptop.fenrus.org> <20041108115353.GA4068@in.ibm.com> Content-Type: text/plain Message-Id: <1099915544.3577.9.camel@laptop.fenrus.org> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2.dwmw2.1) Date: Mon, 08 Nov 2004 13:05:44 +0100 Content-Transfer-Encoding: 7bit X-Spam-Score: 2.6 (++) X-Spam-Report: SpamAssassin version 2.63 on canuck.infradead.org summary: Content analysis details: (2.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.5 RCVD_IN_DYNABLOCK RBL: Sent directly from dynamic IP address [62.195.31.207 listed in dnsbl.sorbs.net] 0.1 RCVD_IN_SORBS RBL: SORBS: sender is listed in SORBS [62.195.31.207 listed in dnsbl.sorbs.net] X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 23 On Mon, 2004-11-08 at 17:23 +0530, Suparna Bhattacharya wrote: > On Mon, Nov 08, 2004 at 11:04:38AM +0100, Arjan van de Ven wrote: > > > +EXPORT_SYMBOL(sync_page_range_nolock); > > > > > > why adding this export? nothing appears to be using it (AIO isn't a module after all) > > > > This doesn't have anything to do with AIO. Filesystems which implement > the equivalent of generic_file_write_nolock may use sync_page_range_nolock > for O_SYNC. > > Does that help clarify ? not really; none do so far so how about not adding the export until someone does use it ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/