Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261177AbUKHSTU (ORCPT ); Mon, 8 Nov 2004 13:19:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261174AbUKHSTC (ORCPT ); Mon, 8 Nov 2004 13:19:02 -0500 Received: from cantor.suse.de ([195.135.220.2]:58570 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S261151AbUKHSSj (ORCPT ); Mon, 8 Nov 2004 13:18:39 -0500 Date: Mon, 8 Nov 2004 18:51:20 +0100 From: Andi Kleen To: Adrian Bunk Cc: Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] kill IN_STRING_C Message-ID: <20041108175120.GB27525@wotan.suse.de> References: <20041107142445.GH14308@stusta.de> <20041108134448.GA2456@wotan.suse.de> <20041108153436.GB9783@stusta.de> <20041108161935.GC2456@wotan.suse.de> <20041108163101.GA13234@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041108163101.GA13234@stusta.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 20 On Mon, Nov 08, 2004 at 05:31:01PM +0100, Adrian Bunk wrote: > On Mon, Nov 08, 2004 at 05:19:35PM +0100, Andi Kleen wrote: > > > Rethinking it, I don't even understand the sprintf example in your > > > changelog entry - shouldn't an inclusion of kernel.h always get it > > > right? > > > > Newer gcc rewrites sprintf(buf,"%s",str) to strcpy(buf,str) transparently. > > Which gcc is "Newer"? I saw it with 3.3-hammer, which had additional optimizations in this area at some point. Note that 3.3-hammer is widely used. I don't know if 3.4 does it in the same way. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/