Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261211AbUKHUDM (ORCPT ); Mon, 8 Nov 2004 15:03:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261215AbUKHUDM (ORCPT ); Mon, 8 Nov 2004 15:03:12 -0500 Received: from smtp-out.hotpop.com ([38.113.3.71]:31646 "EHLO smtp-out.hotpop.com") by vger.kernel.org with ESMTP id S261211AbUKHUCl (ORCPT ); Mon, 8 Nov 2004 15:02:41 -0500 From: "Antonino A. Daplas" Reply-To: adaplas@pol.net To: linux-fbdev-devel@lists.sourceforge.net, Linus Torvalds Subject: Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb Date: Tue, 9 Nov 2004 04:02:19 +0800 User-Agent: KMail/1.5.4 Cc: Linux Fbdev development list , Benjamin Herrenschmidt , Linux Kernel list , Andrew Morton References: <200411080521.iA85LbG6025914@hera.kernel.org> <200411081706.55261.adaplas@hotpop.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200411090402.22696.adaplas@hotpop.com> X-HotPOP: ----------------------------------------------- Sent By HotPOP.com FREE Email Get your FREE POP email at www.HotPOP.com ----------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1907 Lines: 50 On Monday 08 November 2004 23:21, Linus Torvalds wrote: > On Mon, 8 Nov 2004, Antonino A. Daplas wrote: > > How about this patch? This is almost the original macro in riva_hw.h, > > with the __force annotation. > > Why not just use __raw_readl/__raw_writel? > Ok. Tony In big endian machines, the read*/write* accessors do a byteswap for an inherently little endian PCI bus. However, rivafb puts the hardwire in big endian register access, thus the byteswap is not needed. So, instead of read*/write*, use __raw_read*/__raw_write*. Signed-off-by: Antonino Daplas --- diff -Nru a/drivers/video/riva/riva_hw.h b/drivers/video/riva/riva_hw.h --- a/drivers/video/riva/riva_hw.h 2004-11-09 03:45:55 +08:00 +++ b/drivers/video/riva/riva_hw.h 2004-11-09 03:50:32 +08:00 @@ -77,14 +77,18 @@ #include #define NV_WR08(p,i,d) out_8(p+i, d) #define NV_RD08(p,i) in_8(p+i) +#define NV_WR16(p,i,d) (__raw_writew((d), (u16 __iomem *)(p) + (i)/2)) +#define NV_RD16(p,i) (__raw_readw((u16 __iomem *)(p) + (i)/2)) +#define NV_WR32(p,i,d) (__raw_writel((d), (u32 __iomem *)(p) + (i)/4)) +#define NV_RD32(p,i) (__raw_readl((u32 __iomem *)(p) + (i)/4)) #else #define NV_WR08(p,i,d) (writeb((d), (u8 __iomem *)(p) + (i))) #define NV_RD08(p,i) (readb((u8 __iomem *)(p) + (i))) -#endif #define NV_WR16(p,i,d) (writew((d), (u16 __iomem *)(p) + (i)/2)) #define NV_RD16(p,i) (readw((u16 __iomem *)(p) + (i)/2)) #define NV_WR32(p,i,d) (writel((d), (u32 __iomem *)(p) + (i)/4)) #define NV_RD32(p,i) (readl((u32 __iomem *)(p) + (i)/4)) +#endif #define VGA_WR08(p,i,d) NV_WR08(p,i,d) #define VGA_RD08(p,i) NV_RD08(p,i) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/