Date: Mon, 8 Nov 2004 13:52:22 -0800
From: Andrew Morton <akpm@osdl.org>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: linux-kernel@vger.kernel.org, hunold@linuxtv.org
Subject: Re: [patch 1/6] v4l: yet another video-buf interface update
Message-Id: <20041108135222.5edde9f9.akpm@osdl.org>
In-Reply-To: <20041108085116.GA19146@bytesex>
References: <20041108085116.GA19146@bytesex>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 828
Lines: 19

Gerd Knorr <kraxel@bytesex.org> wrote:
>
> This is one more interface fix for the video-buf.c module, the first
> attempt on that wasn't that clever.  Instead of passing the driver
> private data through all function calls I've just made that an element
> of the videobuf_queue struct which is passed around everythere _anyway_.

This patch throws a reject in videobuf_vm_close() because it's expecting

	map->q->ops->buf_release(vma->vm_file,map->q->bufs[i]);
and not
	map->q->ops->buf_release(vma->vm_file->private_data,map->q->bufs[i]);

I'll fix things up, but please check that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/