To: lsr@neapel230.server4you.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Return better error codes from
 vfat_valid_longname()
References: <41901DD1.mail5VX1GOOYK@lsrfire.ath.cx>
	<20041109013848.GC6835@neapel230.server4you.de>
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Date: Wed, 10 Nov 2004 00:28:39 +0900
In-Reply-To: <20041109013848.GC6835@neapel230.server4you.de> (lsr@neapel230.server4you.de's
 message of "Tue, 9 Nov 2004 02:38:48 +0100")
Message-ID: <87vfcf3uu0.fsf@devron.myhome.or.jp>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 929
Lines: 21

lsr@neapel230.server4you.de writes:

> Currently vfat returns -EINVAL if one tries to create a file or directory
> with an invalid name. This patch changes vfat_valid_longname() to return
> a more specific error code.
>
> POSIX doesn't define a nice error code for invalid filenames, so I chose
> EACCES -- unlike EINVAL this is a valid error code of mkdir(2). Hope it
> sort of fits. (EINVAL did *not* fit; it generally seems to point to
> problems not with the filename  but with e.g. the flags value of open(2)
> etc.).

Yes, the error code for this should be consistent on _system_.
Until we do it, this change would not be useful.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/