Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262026AbUKJSFG (ORCPT ); Wed, 10 Nov 2004 13:05:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262029AbUKJSFG (ORCPT ); Wed, 10 Nov 2004 13:05:06 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:5094 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S262026AbUKJSFB (ORCPT ); Wed, 10 Nov 2004 13:05:01 -0500 Date: Wed, 10 Nov 2004 19:04:22 +0100 From: Jens Axboe To: Adam Heath Cc: Robert Love , Carl-Daniel Hailfinger , Linux Kernel Mailing List Subject: Re: [RFC] [PATCH] kmem_alloc (generic wrapper for kmalloc and vmalloc) Message-ID: <20041110180422.GS5602@suse.de> References: <4191A4E2.7040502@gmx.net> <1100066597.18601.124.camel@localhost> <20041110075450.GB5602@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 663 Lines: 20 On Wed, Nov 10 2004, Adam Heath wrote: > On Wed, 10 Nov 2004, Jens Axboe wrote: > > > Plus, you cannot use vfree() from interrupt context. This patch is a bad > > idea. > > why not have a work queue, that frees things later, after a delay? Kludge upon kludge does not make the interface any better. The best fix is to split the allocations, like suggested a slab cache for the loop would do nicely. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/