Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262153AbUKKA2l (ORCPT ); Wed, 10 Nov 2004 19:28:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262156AbUKKA0C (ORCPT ); Wed, 10 Nov 2004 19:26:02 -0500 Received: from fw.osdl.org ([65.172.181.6]:29130 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262166AbUKKAYP (ORCPT ); Wed, 10 Nov 2004 19:24:15 -0500 Date: Wed, 10 Nov 2004 16:24:01 -0800 (PST) From: Linus Torvalds To: Arnaldo Carvalho de Melo , Len Brown cc: Kernel Mailing List Subject: Re: [PATCH] fix platform_rename_gsi related ia32 build breakage In-Reply-To: <4192ADF4.1050907@conectiva.com.br> Message-ID: References: <4192A959.9020806@conectiva.com.br> <4192A9BF.2080606@conectiva.com.br> <4192ADF4.1050907@conectiva.com.br> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 24 On Wed, 10 Nov 2004, Arnaldo Carvalho de Melo wrote: > > This one compiles and links OK. Including when CONFIG_ACPI_BOOT is set? Does it see the prototype then? Looks like should be included, but I assume it gets included some other way? Quite frankly, I think the whole thing is broken. #ifdef's inside code is _evil_, and "platform_rename_gsi()" doesn't make sense as a name. I'll apply your patch, but quite frankly, I think the ACPI layer is doing crap. Len, can you please use a more descriptive name, and have it be always defined (make it an inline function that just becomes a no-op or something). Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/