Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262155AbUKKAem (ORCPT ); Wed, 10 Nov 2004 19:34:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262151AbUKKAem (ORCPT ); Wed, 10 Nov 2004 19:34:42 -0500 Received: from fw.osdl.org ([65.172.181.6]:14034 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262155AbUKKAef (ORCPT ); Wed, 10 Nov 2004 19:34:35 -0500 Date: Wed, 10 Nov 2004 16:38:39 -0800 From: Andrew Morton To: Arnaldo Carvalho de Melo Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix platform_rename_gsi related ia32 build breakage Message-Id: <20041110163839.298380f8.akpm@osdl.org> In-Reply-To: <4192A959.9020806@conectiva.com.br> References: <4192A959.9020806@conectiva.com.br> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i586-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 17 Arnaldo Carvalho de Melo wrote: > > --- 1.116/arch/i386/kernel/io_apic.c 2004-10-28 05:35:33 -03:00 > +++ edited/arch/i386/kernel/io_apic.c 2004-11-10 21:39:57 -02:00 > @@ -1039,6 +1039,8 @@ > return MPBIOS_trigger(idx); > } > > +extern int (*platform_rename_gsi)(int ioapic, int gsi); This defeats compiler typechecking. Please place extern declarations in header files where they are visible to the definition and to all users. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/