Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262221AbUKKLZA (ORCPT ); Thu, 11 Nov 2004 06:25:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262211AbUKKLWy (ORCPT ); Thu, 11 Nov 2004 06:22:54 -0500 Received: from e32.co.us.ibm.com ([32.97.110.130]:47082 "EHLO e32.co.us.ibm.com") by vger.kernel.org with ESMTP id S262214AbUKKLU4 (ORCPT ); Thu, 11 Nov 2004 06:20:56 -0500 Message-ID: <41934AE8.7040008@in.ibm.com> Date: Thu, 11 Nov 2004 16:50:08 +0530 From: Sripathi Kodi User-Agent: Mozilla Thunderbird 0.8 (X11/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Linus Torvalds CC: Dinakar Guniguntala , linux-kernel@vger.kernel.org, Roland McGrath , Ingo Molnar , Andrew Morton Subject: Re: [PATCH] do_wait fix for 2.6.10-rc1 References: <418B4E86.4010709@in.ibm.com> <418F826C.2060500@in.ibm.com> <20041109143118.GA8961@in.ibm.com> <20041110143518.GC4502@in.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 34 Linus Torvalds wrote: >On Wed, 10 Nov 2004, Dinakar Guniguntala wrote: > > >>How about if we set the flag only in the cases when the exit state is not >>either TASK_DEAD or TASK_ZOMBIE. >> >> > >Why TASK_DEAD? We can't reap such a process anyway, no? But yes, I agree >with the approach. > > Linus > > Linus, Yes, when we see a process in TASK_DEAD state, we can't reap it. We shouldn't set the flag in this scenario because we have not really found an eligible child (one in any state other than TASK_DEAD). So we need to go back to parsing the list of children as if we have not found an eligible child at all. Please let us know if this argument is correct and if we have reached the final shape for this fix. Thanks, Sripathi. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/