Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262258AbUKKPnp (ORCPT ); Thu, 11 Nov 2004 10:43:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262251AbUKKPmf (ORCPT ); Thu, 11 Nov 2004 10:42:35 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:23425 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S262246AbUKKPkS (ORCPT ); Thu, 11 Nov 2004 10:40:18 -0500 Date: Thu, 11 Nov 2004 15:40:17 +0000 From: Matthew Wilcox To: Adrian Bunk Cc: Matthew Wilcox , Len Brown , Arnaldo Carvalho de Melo , ACPI Developers , linux-kernel@vger.kernel.org Subject: Re: [ACPI] [2.6 patch] drivers/acpi: #ifdef unused functions away Message-ID: <20041111154017.GC1108@parcelfarce.linux.theplanet.co.uk> References: <20041105215021.GF1295@stusta.de> <1099707007.13834.1969.camel@d845pe> <20041106114844.GK1295@stusta.de> <418CEE3A.40503@conectiva.com.br> <20041106212917.GP1295@stusta.de> <418D403E.30608@conectiva.com.br> <1099933263.13831.9547.camel@d845pe> <20041110012134.GB4089@stusta.de> <20041111151727.GB1108@parcelfarce.linux.theplanet.co.uk> <20041111153650.GD8417@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041111153650.GD8417@stusta.de> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 34 On Thu, Nov 11, 2004 at 04:36:50PM +0100, Adrian Bunk wrote: > On Thu, Nov 11, 2004 at 03:17:27PM +0000, Matthew Wilcox wrote: > > On Wed, Nov 10, 2004 at 02:21:34AM +0100, Adrian Bunk wrote: > > > This patch only #ifdef's completely unused code away - it does not make > > > the many global functions only used inside the file they are defined in > > > static. > > > > It also ifdefs out the acpi_install_gpe_handler and acpi_remove_gpe_handler > > calls I use in the driver I posted on Sunday. Please fix this. > > ???? > > My patch doesn't #ifdef these functions away. Sorry, acpi_remove_gpe_block, not acpi_remove_gpe_handler: @@ -383,6 +398,7 @@ acpi_status acpi_remove_gpe_block ( acpi_handle gpe_device); +#endif /* ACPI_FUTURE_USAGE */ -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/