Message-ID: <4193AAEE.1000800@fujitsu-siemens.com>
Date: Thu, 11 Nov 2004 19:09:50 +0100
From: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913
MIME-Version: 1.0
To: Jeff Dike <jdike@addtoit.com>
CC: akpm@osdl.org, Blaisorblade <blaisorblade_spam@yahoo.it>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UML - signal bug fix
References: <200411111957.iABJvHPV004137@ccure.user-mode-linux.org>
In-Reply-To: <200411111957.iABJvHPV004137@ccure.user-mode-linux.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 923
Lines: 20

Jeff Dike wrote:
> This patch fixes a bug introduced in the last batch of signal fixes.  The
> system call return value should only be reset if called diectly from a system
> call, i.e. sigsuspend.  The fixes added earlier caused any interrupted non-zero
> system call return to be reset, confusing fork and vfork, among others.
> 
> Signed-off-by: Jeff Dike <jdike@addtoit.com>
> 
Yes. The patchset was wrong.
But IMHO the solution shouldn't be resetting to the old state, that did syscall
restarting wrong!
The problem, you fix here, doesn't occur, when using my complete patchset. And my
patches fix UML's wrong syscall restart handling. And other issues they fix, too.

Bodo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/