Date: Thu, 11 Nov 2004 14:41:53 -0800
From: Andrew Morton <akpm@osdl.org>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: 2.6.10-rc1-mm5
Message-Id: <20041111144153.588094d2.akpm@osdl.org>
In-Reply-To: <111920000.1100210158@flay>
References: <20041111012333.1b529478.akpm@osdl.org>
	<20041111030837.12a2090b.akpm@osdl.org>
	<111920000.1100210158@flay>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1442
Lines: 38

"Martin J. Bligh" <mbligh@aracnet.com> wrote:
>
>  That works. But something broke shmem:
> 
>  ipc/shm.c:171: error: `shmem_set_policy' undeclared here (not in a function)
>  ipc/shm.c:171: error: initializer element is not constant
>  ipc/shm.c:171: error: (near initialization for `shm_vm_ops.set_policy')
>  ipc/shm.c:172: error: `shmem_get_policy' undeclared here (not in a function)
>  ipc/shm.c:172: error: initializer element is not constant
>  ipc/shm.c:172: error: (near initialization for `shm_vm_ops.get_policy')

OK, I tracked this down to another secret dhowells diff.

 config SHMEM
-       default y
-       bool "Use full shmem filesystem" if EMBEDDED && MMU
+       bool "Use full shmem filesystem"
+       default y if EMBEDDED
+       depends on MMU

This change permits CONFIG_SHMEM=n on !CONFIG_MMU, even if !EMBEDDED.  Or
something.  I'm not really sure what it's trying to do, nor am I clear on
what semantics we wanted to have for CONFIG_SHMEM on CONFIG_MMU machines.

I think the semantics we want are: you always get shmem, unless you
selected EMBEDDED.  So perhaps we want:

config SHMEM
	bool "Use full shmem filesystem" if EMBEDDED
	depends on MMU
	default y if MMU


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/