Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262497AbUKLK2s (ORCPT ); Fri, 12 Nov 2004 05:28:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262500AbUKLK2r (ORCPT ); Fri, 12 Nov 2004 05:28:47 -0500 Received: from mtagate2.de.ibm.com ([195.212.29.151]:36529 "EHLO mtagate2.de.ibm.com") by vger.kernel.org with ESMTP id S262497AbUKLK2W (ORCPT ); Fri, 12 Nov 2004 05:28:22 -0500 In-Reply-To: Subject: Re: [patch 4/10] s390: network driver. To: linux-kernel@vger.kernel.org Cc: jgarzik@pobox.com X-Mailer: Lotus Notes Release 6.0.2CF1 June 9, 2003 Message-ID: From: Thomas Spatzier Date: Fri, 12 Nov 2004 11:28:39 +0100 X-MIMETrack: Serialize by Router on D12ML061/12/M/IBM(Release 6.0.2CF2HF259 | March 11, 2004) at 12/11/2004 11:28:19 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 26 > You should be using netif_carrier_{on,off} properly, and not drop the > packets. When (if) link comes back, you requeue the packets to hardware > (or hypervisor or whatever). Your dev->stop() should stop operation and > clean up anything left in your send/receive {rings | buffers}. > When we do not drop packets, but call netif_stop_queue the write queues of all sockets associated to the net device are blocked as soon as they get full. This causes problems with programs such as the zebra routing daemon. So we have to keep the netif queue running in order to not block any programs. We also had a look at some other drivers and the common behaviour seems to be that packets are lost if the network cable is pulled out. Regards, Thomas. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/