Message-Id: <200411122220.iACMKpjw014426@death.nxdomain.ibm.com>
To: "David S. Miller" <davem@davemloft.net>
cc: radheka.godse@intel.com, bonding-devel@lists.sourceforge.net,
       ctindel@users.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Bonding-devel][PATCH]Zero Copy Transmit Support (Update) 
In-Reply-To: Message from "David S. Miller" <davem@davemloft.net> 
   of "Fri, 12 Nov 2004 13:49:18 PST." <20041112134918.305379c4.davem@davemloft.net> 
Date: Fri, 12 Nov 2004 14:20:51 -0800
From: Jay Vosburgh <fubar@us.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 930
Lines: 26

David S. Miller <davem@davemloft.net> wrote:
>That's definitely a good start.
>
>It does need to be fixed to enforce the usual rules about
>illegal combinations.  And his code is going to include
>all sorts of weird things like VLAN offload which I wonder
>if works correctly with the current bonding driver? :)

	The existing code should handle VLANs correctly, and the patch
excludes the VLAN related bits from the dev->features update.

>The two rules are codified in register_netdevice() as follows:
[...]

	Would it be preferrable to duplicate that logic in bonding, or
push it out to an inline or some such?

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/